Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support XDG Base directory specification for Linux #264

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

WhiredPlanck
Copy link

@WhiredPlanck WhiredPlanck commented Jan 3, 2025

This PR will fix Issue Aegisub#226. Adapted from aria2/aria2@8bc1d37.

The basic idea just is:

  • If $HOME/.aegisub exists, then the program will still read/write config/cache/data/state from there;
  • If $HOME/.aegisub doesn't exist, then the program will read/write config/cache/data/state from corresponding XDG base Directory.

The original PR is here: wangqr#132

@witchymary
Copy link
Contributor

witchymary commented Jan 4, 2025

I'm pretty sure this will still run into the issues I fixed here: arch1t3cht@b5a071b

Also worth noting that this will break regardless due to this line in Dependency Control (https://github.com/TypesettingTools/DependencyControl/blob/9b8d615f18e295f4777ea606a7173465bdaf140d/modules/DependencyControl/Record.moon#L44). It needs to be changed in there as well

libaegisub/unix/path.cpp Outdated Show resolved Hide resolved
@WhiredPlanck
Copy link
Author

I'm pretty sure this will still run into the issues I fixed here: arch1t3cht@b5a071b

Also worth noting that this will break regardless due to this line in Dependency Control (https://github.com/TypesettingTools/DependencyControl/blob/9b8d615f18e295f4777ea606a7173465bdaf140d/modules/DependencyControl/Record.moon#L44). It needs to be changed in there as well

You're right, I will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants