Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a setting to control whether to respect advisory rate limits #1342

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Tyrrrz
Copy link
Owner

@Tyrrrz Tyrrrz commented Feb 6, 2025

Closes #1021

  • CLI: --respect-rate-limits [true/false]
  • GUI: Settings -> Rate Limit Preference
    • Note: you have to re-pull your servers (press the -> arrow button) after you change your rate limit preferences, for the changes to take effect.

When disabled, DCE only considers Retry-After headers when the response code is 429 and not any of the other advisory retry headers.

@Tyrrrz Tyrrrz requested a review from Copilot February 6, 2025 18:49
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • DiscordChatExporter.Gui/Views/Dialogs/SettingsView.axaml: Language not supported
  • DiscordChatExporter.Gui/Services/SettingsService.cs: Evaluated as low risk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export hangs and doesn't continue
1 participant