Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use screenRect.Left and screenRect.Top when checking for fullscreen boundaries #267

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Use screenRect.Left and screenRect.Top when checking for fullscreen boundaries #267

merged 1 commit into from
Jan 30, 2024

Conversation

lamrongol
Copy link
Contributor

Related Issue is #16

@Tyrrrz
Copy link
Owner

Tyrrrz commented Jan 30, 2024

Can you explain please how this is related to #16?

@lamrongol
Copy link
Contributor Author

lamrongol commented Jan 30, 2024

@Tyrrrz Multis screens exist and they don't stand in line, sub(second) window top and left is not zero, like following:

image

@Tyrrrz
Copy link
Owner

Tyrrrz commented Jan 30, 2024

The thing is that screenRect is that for the screen where the window is displayed, so it's not dependent on other screens. I think it's still harmless to merge, but I don't think it will affect #16 in any way.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9f15a7a) 96.35% compared to head (0b40cab) 96.35%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #267   +/-   ##
=======================================
  Coverage   96.35%   96.35%           
=======================================
  Files           7        7           
  Lines         192      192           
  Branches       15       15           
=======================================
  Hits          185      185           
  Misses          6        6           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tyrrrz Tyrrrz changed the title Fix for multi screen Use screenRect.Left and screenRect.Top when checking for fullscreen boundaries Jan 30, 2024
@Tyrrrz Tyrrrz merged commit eb288f6 into Tyrrrz:master Jan 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants