youtube-dl refactor #956
youtube-dl refactor #956
Conversation
Tzahi12345
commented
Jun 6, 2023
•
Tzahi12345
commented
- Refactored youtube-dl.js
- Removes dependency on deprecated node-youtube-dl (closes [DEPENDENCIES <very low priority>] Use more advanced youtube-dl library #111)
- Added ability to cancel downloads
- Added ability to manually kick off subscription checks (fixes [FEATURE] Manually download videos from subscription. #871) and cancel those checks
- Added ability to have multiple binaries present (e.g. youtube-dl, yt-dlp). If you change it and it doesn't exist, it will be downloaded at runtime
- Tests
- Added additional downloader and subscription tests
- Fixed test related to twitch VODs
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…dl library Downloads can now be cancelled and better "paused"
| @@ -1305,6 +1289,36 @@ | |||
| }); | |||
| }); | |||
|
|
|||
| app.post('/api/checkSubscription', optionalJwt, async (req, res) => { | |||
Check failure
Code scanning / CodeQL
Missing rate limiting High
| app.post('/api/checkSubscription', optionalJwt, async (req, res) => { | ||
| let sub_id = req.body.sub_id; | ||
| let user_uid = req.isAuthenticated() ? req.user.uid : null; | ||
|
|
||
| const success = subscriptions_api.getVideosForSub(sub_id, user_uid); | ||
| res.send({ | ||
| success: success | ||
| }); | ||
| }); |
Check failure
Code scanning / CodeQL
Missing rate limiting High
| }); | ||
| }); | ||
|
|
||
| app.post('/api/cancelCheckSubscription', optionalJwt, async (req, res) => { |
Check failure
Code scanning / CodeQL
Missing rate limiting High
| app.post('/api/cancelCheckSubscription', optionalJwt, async (req, res) => { | ||
| let sub_id = req.body.sub_id; | ||
| let user_uid = req.isAuthenticated() ? req.user.uid : null; | ||
|
|
||
| const success = subscriptions_api.cancelCheckSubscription(sub_id, user_uid); | ||
| res.send({ | ||
| success: success | ||
| }); | ||
| }); |
Check failure
Code scanning / CodeQL
Missing rate limiting High
| }); | ||
| }); | ||
|
|
||
| app.post('/api/cancelSubscriptionCheck', optionalJwt, async (req, res) => { |
Check failure
Code scanning / CodeQL
Missing rate limiting High
| app.post('/api/cancelSubscriptionCheck', optionalJwt, async (req, res) => { | ||
| let sub_id = req.body.sub_id; | ||
| let user_uid = req.isAuthenticated() ? req.user.uid : null; | ||
|
|
||
| const success = subscriptions_api.getVideosForSub(sub_id, user_uid); | ||
| res.send({ | ||
| success: success | ||
| }); | ||
| }); |
Check failure
Code scanning / CodeQL
Missing rate limiting High
…will be downloaded at runtime
…h before proceeding
Tzahi12345
force-pushed
the
youtubedl-refactor
branch
from
e21f0a3 to
58811a7
Compare
|
I saw the docker change, as the default user is not root, I think the nvm and it node installation path should be somewhere accessed to all like |
Yeah good point. It's still WIP as I'm wrestling with git but I'll make that change! |
