Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dummy plugin #143

Merged
merged 1 commit into from
May 4, 2018
Merged

Remove dummy plugin #143

merged 1 commit into from
May 4, 2018

Conversation

stweil
Copy link
Member

@stweil stweil commented Mar 23, 2018

It is not needed anywhere.

Signed-off-by: Stefan Weil [email protected]

It is not needed anywhere.

Signed-off-by: Stefan Weil <[email protected]>
@stweil
Copy link
Member Author

stweil commented Mar 23, 2018

Would it be better to have the plugins directory as part of the site configuration which currently is below the theme directory? Maybe the directory structure should look like this:

(PalMA root)
|
site
|
+----+--- ...
|    |
demo ub-mannheim
|    |
...  +------+--- ...
     |      |
     a3     a5
     |
     +------+
     |      |
     theme  plugins
     |      |
     ...    ...

@dennmuel
Copy link
Member

The dummy was once intended to show that people could insert their own php-plugins here. I'm fine with the deletion. Perhaps we could add some words about plugin coding in the documentation and/or a small readme in the plugins folder.
Directory structure generally could be discussed in #113 .

@stweil stweil merged commit fd4d0fc into master May 4, 2018
@stweil stweil deleted the plugins branch May 4, 2018 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants