BackupFileRotationTest: Fix resource leaks on exceptional path

Errors reported by Coverity Scan: CID 50569 (#1 of 1): Resource leak on an exceptional path (RESOURCE_LEAK) CID 50570 (#1 of 1): Resource leak on an exceptional path (RESOURCE_LEAK) Signed-off-by: Stefan Weil <[email protected]>
UB-Mannheim · Sep 23, 2016 · bbb3759 · bbb3759
1 parent e7265f8
commit bbb3759
Showing 1 changed file with 10 additions and 9 deletions.
diff --git a/Goobi/test/src/org/goobi/io/BackupFileRotationTest.java b/Goobi/test/src/org/goobi/io/BackupFileRotationTest.java
@@ -197,12 +197,13 @@ private void runBackup(int numberOfBackups, String format) throws IOException {
 
 	private void assertFileHasContent(String fileName, String expectedContent) throws IOException {
 		File testFile = new File(fileName);
-		FileReader reader = new FileReader(testFile);
-		BufferedReader br = new BufferedReader(reader);
-		String content = br.readLine();
-		br.close();
-		reader.close();
-		assertEquals("File " + fileName + " does not contain expected content:", expectedContent, content);
+		try (
+			FileReader reader = new FileReader(testFile);
+			BufferedReader br = new BufferedReader(reader);
+		) {
+			String content = br.readLine();
+			assertEquals("File " + fileName + " does not contain expected content:", expectedContent, content);
+		}
 	}
 
 	private void assertFileExists(String fileName) {
@@ -232,9 +233,9 @@ private void deleteFile(String fileName) {
 
 	private void writeFile(String fileName, String content) throws IOException {
 		File testFile = new File(fileName);
-		FileWriter writer = new FileWriter(testFile);
-		writer.write(content);
-		writer.close();
+		try (FileWriter writer = new FileWriter(testFile)) {
+			writer.write(content);
+		}
 	}
 
 }