Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more flexible about QID in extra field #93

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

diegodlh
Copy link

The QuickStatements export translator intentionally doesn't output anything if the item already has a QID in the extra field. However, it is strict about the format how it has to be specified: "^QID: " (uppercase "QID" at the beginning of the line, followed by ":", followed by space".

Although this seems to be the format suggested in the Zotero documentation, and it has been said that it is Zotero's main developer preferred way, they don't seem to be strict about it.

Do you think we could make it more flexible? That is, case-insensitive and with or without a space after the colon?

BTW, apart from this translator and the Wikicite plugin I'm developing, do you know of any other plugin/translator that expects the QID to be in the extra field? The Wikidata web translator currently doesn't, as proposed that it does here.

@zuphilip
Copy link
Member

The changes look fine in general (still thinking about the space and wether it makes a difference...), but the repo for this translator changed.

The QuickStatements translator was now in the meantime integrated in the official Zotero translator repository zotero/translators#2339 and therefore you should place a pull request there. I need to do some follow-ups here and especially to link to the new and official version of the translator.

Thanks for adding the QID field to the web translator. I was quite sure that it was there already, because that is the whole idea how to avoid duplicates from exporting items which have been imported before already from Wikidata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants