Func util empty arr

[InderKhera]

• created tests for non-empty array to be handled
• created tests to ensure dimensions of numpy array align with 2d grayscale array or 3d RGB array

[Arc-Celt]

Well done with the utility function for numpy shape and thanks for adding the dependencies Inder! Just a few thoughts on the test:

• I see that right now you have one error case that is a 1D array. You could try adding more expected test cases as well as edge cases as well, so that each category has more than 2 test cases. Here are some cases I thought of:
  • Expected cases: valid 2D array, and valid 3D array.
  • Edge cases: 1 pixel 2D or 3D array, arrays containing different datatypes such as float.
  • Error cases: the 1D array you wrote, empty array, zero-sized-deminsion array.
• (Optional) As Jenny suggested, you can use pytest's decorator we learnt today pytest.mark.parametrize to have multiple test cases combined together to reduce duplication. This is how I used it for your reference.

[InderKhera]

@Arc-Celt Thanks for bringing this up, it looks like I had an issue with my push to the remote where only one of the cases showed up. I will amend this as well as use the pytest.mark.parametrize

[Arc-Celt]

I just ran pytest and found that the cases for test_erroneous_image_format and test_zero_size_dimensions didn't raise ValueError, which is strange because when I tried your test cases to see if they would raise the ValueError, they did it correctly. Is pytest working on your side that all the test cases pass?

[Arc-Celt]

Everything looks good to me now! One thing to note is that you don't need to explicitly write return None in the _input_checker function, as it will automatically return None if there is no return statement.