Skip to content
This repository has been archived by the owner on Mar 23, 2024. It is now read-only.

Write wingsail subscription logic #16

Conversation

alberto-escobar
Copy link
Contributor

Description

Verification

  1. Changed topic in __gps_sub from "gps" to "mock_gps"
  2. Ran the sailbot workspace and observed the following in the terminal:

[wingsail_ctrl_node-1] [INFO] [1700961182.173811623] [wingsail_ctrl_node:118]: Received data from mock_gps

  1. Changed topic in __gps_sub back to "gps"

Resources

  • None

Copy link
Contributor

@DFriend01 DFriend01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Just a few comments and you're good to go! When you are done, be sure to re-request a review (look at the top right of the PR page and click on the button that says to request a review from me).

default.profraw Outdated Show resolved Hide resolved
controller/wingsail/wingsail_ctrl_node.py Outdated Show resolved Hide resolved
controller/wingsail/wingsail_ctrl_node.py Outdated Show resolved Hide resolved
controller/wingsail/wingsail_ctrl_node.py Outdated Show resolved Hide resolved
@alberto-escobar
Copy link
Contributor Author

I implemented changes to resolve all your comments, please review and let me know if there is anything left unresolved.

@DFriend01 DFriend01 changed the title User/alberto escobar/11 write wingsail subscription logic Write wingsail subscription logic Nov 30, 2023
@alberto-escobar alberto-escobar merged commit 3732938 into main Dec 1, 2023
12 checks passed
@alberto-escobar alberto-escobar deleted the user/alberto-escobar/11-write-wingsail-subscription-logic branch December 1, 2023 02:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write Wingsail Subscription Logic
2 participants