Skip to content
This repository has been archived by the owner on Mar 23, 2024. It is now read-only.

Logged Inactive Subscribers #86

Merged
merged 5 commits into from
Feb 18, 2024
Merged

Conversation

Krithik1
Copy link
Contributor

Description

  • Resolves Log inactive subscribers #85
  • Checks if the 4 subscribers are None. If yes, then a warning is logged.
  • Function definition in node_navigate.py

@Krithik1 Krithik1 linked an issue Feb 11, 2024 that may be closed by this pull request
Copy link
Contributor

@jamenkaye jamenkaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I added one thing to consider 👍

local_pathfinding/node_navigate.py Outdated Show resolved Hide resolved
@Krithik1 Krithik1 requested a review from jamenkaye February 14, 2024 19:56
Copy link
Contributor

@jamenkaye jamenkaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great implementation! If you could please change the warning messages to contain the exact topic names in custom interfaces, this will be ready to get merged in!

You can go ahead and merge this as soon as you make the change :)

@Krithik1 Krithik1 merged commit 624ab28 into main Feb 18, 2024
12 checks passed
@Krithik1 Krithik1 deleted the user/Krithik1/Log_Inactive_Subscribers branch February 18, 2024 22:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log inactive subscribers
2 participants