Skip to content
This repository has been archived by the owner on Mar 23, 2024. It is now read-only.

Migrate Local Pathfinding Python Dependencies to package.xml #90

Merged

Conversation

SPDonaghy
Copy link
Contributor

Description

Added local_pathfinding Python dependencies to the package.xml file
I also removed these dependencies from the base-dev.Dockerfile in a separate SailbotWorkspace branch.

I did not remove NumPy from the Dockerfile, but I still added it to package.xml, which might be redundant but it does make it clear that this package specifically depends on NumPy.

The OMPL dependency is still defined in the base-dev.Dockerfile.

Verification

  1. I removed the Python dependencies from base-dev.Dockerfile, then built a new image based off of the new Dockerfile.
  2. I modified the Dev Container Dockerfile to use this new image and rebuilt the container.
  3. I ran the setup task and then the command pip3 list
  4. The Python dependencies specifed both in base-dev.Dockerfileand in local_pathfinding/package.xml were all installed successfully

Copy link
Member

@patrick-5546 patrick-5546 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create a sailbot workspace PR for your branch there? We can present this in the software-wide meeting tomorrow

@SPDonaghy SPDonaghy merged commit 350ca78 into main Feb 24, 2024
12 checks passed
@SPDonaghy SPDonaghy deleted the user/SPDonaghy/migrate-package-specific-dependencies-242 branch February 24, 2024 18:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants