This repository has been archived by the owner on Mar 23, 2024. It is now read-only.
Migrate Local Pathfinding Python Dependencies to package.xml #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added local_pathfinding Python dependencies to the package.xml file
I also removed these dependencies from the base-dev.Dockerfile in a separate SailbotWorkspace branch.
I did not remove NumPy from the Dockerfile, but I still added it to package.xml, which might be redundant but it does make it clear that this package specifically depends on NumPy.
The OMPL dependency is still defined in the base-dev.Dockerfile.
Verification
base-dev.Dockerfile
, then built a new image based off of the new Dockerfile.setup
task and then the commandpip3 list
base-dev.Dockerfile
and inlocal_pathfinding/package.xml
were all installed successfully