-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
can_transceiver.cpp: Added /SimulatorFeedback pub Added stubcode for cmake
…-Sim-Interface-Stubs
Added callback functions for both
Cleaned up code
Noted all known issues in comments and issue page Properly works with ros2 run command & boat sim on
- Replaced 'auto' within simulation interface
Hey Henry, I have:
Should be ready for merge |
Make to follow ROS style guidelines, in particular for variables: http://wiki.ros.org/CppStyleGuide#Variables. |
For every .cpp and .h file you've touched, open the command palette ( |
I have auto-save off on vscode, I normally just click ctrl + s after a couple lines out of muscle memory, is the formatting not working / not expected what it should look like? I've ran the formatter under command palette either way, with clangd format |
Formatting was broken and I didn't catch it because of one of my user settings. I'll fix it soon. Thanks for catching this. Edit: Fixed in: UBCSailbot/sailbot_workspace#202 |
Take another look at this. Particularly for variable names. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be misunderstanding for how the CanSimIntf plugs in to the overall software flow alongside the regular CanTransceiverIntf. We'll need to talk about this more in depth.
I've changed all variables and member variable names to underscored and lower case |
Description
Verification
Resources