Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update low level control node with implemented controllers #425

Open
eomielan opened this issue Aug 6, 2024 · 2 comments · May be fixed by #445
Open

Update low level control node with implemented controllers #425

eomielan opened this issue Aug 6, 2024 · 2 comments · May be fixed by #445
Assignees
@alberto-escobar
Labels
enhancement New feature or request sim Boat Simulator team

Comments

@eomielan
Copy link
Member

eomielan commented Aug 6, 2024

Purpose

The purpose of this issue is to update the low level control node (boat_simulator/nodes/low_level_control/low_level_control_node.py) to use the implemented rudder and sail actuation controllers.

Changes

Update __rudder_actuation_routine() to use the implemented rudder controller and __sail_actuation_routine() to use the implemented sail controller.

Resources
@eomielan eomielan added the enhancement New feature or request label Aug 6, 2024
@github-project-automation github-project-automation bot moved this to Backlog in SOFT Project Aug 6, 2024
@eomielan eomielan added the sim Boat Simulator team label Aug 6, 2024
@alberto-escobar
Copy link
Contributor

this commit I pushed 83a9841 and contains a preliminary implementation for the issue. How do I test if it is working?

@alberto-escobar
Copy link
Contributor

Testing blocked by errors in physics engine node

@alberto-escobar alberto-escobar linked a pull request Oct 26, 2024 that will close this issue
Preliminary Resolution for #425 update low level control node #445
Open
@alberto-escobar alberto-escobar linked a pull request Oct 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alberto-escobar alberto-escobar

Labels
enhancement New feature or request sim Boat Simulator team
Projects
SOFT Project
Status: Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Preliminary Resolution for #425 update low level control node UBCSailbot/sailbot_workspace
2 participants
@alberto-escobar @eomielan