Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preliminary Resolution for #425 update low level control node #445

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Preliminary Resolution for #425 update low level control node #445

wants to merge 8 commits into from

Conversation

alberto-escobar
Copy link
Contributor

@alberto-escobar alberto-escobar commented Oct 26, 2024 •
edited
Loading

Description

Verification

  • I will work on making more formal tests. The big hurdle is that testing of implementation relies on other packages and some are crashing during running resulting in my code never being reached. The other big hurdle is ROS2 is very complicated and I need to take some time understanding what I am doing.

Resources

  • N/A

alberto-escobar and others added 8 commits September 17, 2024 10:56
@alberto-escobar
preliminary implementation, no testing done
83a9841
@eomielan @alberto-escobar
Simulator dimension mismatches & fluid generation config (#435)
c29c03c 
* Fix issues in model and physics node

* Fix dimension mismatching

* Fix comments for constants

* Allow wind & current generation config

* Allow config of fluid cov in globals.yaml

* Prevent data collection from making file when not in use

* Fix formatting issues with README for ci

* Update fluid generation unit tests
@SPDonaghy @alberto-escobar
Land Data Generator Script (#434)
3964bd0 
* brought in changes from old branch

* updated pkg xml with required dependencies

* updated pkg xml and requirements

* added jupyter notebook, ignore array type in obstacles

* updated license info

* updated script to apply consistent 12.5NM buffer

* printing heads

* ended friendship with shapefile, friends with geojson now

* removed geopandas and fiona!

* some metadata changes to notebook

* implemented buffer amount, its set at 5000 meters right now

* updated generation to include buffer

* metadata

---------

Co-authored-by: Sean Donaghy <[email protected]>
@JordanChen123 @alberto-escobar
production db setup (#437)
a3337c6
@lross03 @alberto-escobar
Implemented power mode frame and ROS callbacks send data to CAN (#428)
420e27c
@alberto-escobar
Fixed minor bug in getting current_heading for rudder_actuation_routine
593fe37
@alberto-escobar
Merge branch 'main' into alberto-escobar/425-update-low-level-control…
acc685d 
…-node
@alberto-escobar
fixed some minor issues with getting values from goal_handler and par…
084b7b2 
…ameters
@alberto-escobar alberto-escobar linked an issue Oct 26, 2024 that may be closed by this pull request
Update low level control node with implemented controllers #425
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eomielan eomielan Awaiting requested review from eomielan eomielan is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees

@alberto-escobar alberto-escobar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update low level control node with implemented controllers
5 participants
@alberto-escobar @eomielan @SPDonaghy @JordanChen123 @lross03