Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed verify.go to accept both slash and interaction based verification #7

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JustIceO7
Copy link

@JustIceO7 JustIceO7 commented Sep 30, 2024

Changed verify.go to accept both slash and interaction based verification. Added automatic signups role creation as well as created time.go utility function which returns current time

@v-pan v-pan self-requested a review October 5, 2024 16:07
Copy link

@v-pan v-pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just commented some places we can add configs in another PR


_, month, year := utils.GetTime()

roleName := "Signups "
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can pull this from a viper config in future.

func GetTime() (int, int, int) {
currentTime := time.Now()

parsedTime, _ := time.Parse("02-01-2006", currentTime.Format("02-01-2006"))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also can pull the format from a viper config in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants