Misc

UCL-INGI · Oct 22, 2024 · b07487f · b07487f
1 parent 262f9fd
commit b07487f
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 4 deletions.
diff --git a/inginious/frontend/lti_grade_manager.py b/inginious/frontend/lti_grade_manager.py
@@ -73,7 +73,6 @@ def run(self):
                 try:
                     course = self._app.course_factory.get_course(courseid)
                     task = course.get_task(taskid)
-                    print(self._app.user_manager.get_task_cache(username, courseid, task.get_id()))
                     grade = self._app.user_manager.get_task_cache(username, courseid, task.get_id())["grade"]
                 except Exception:
                     self._logger.error("An exception occurred while getting a course/LTI secret/grade in LTIGradeManager.", exc_info=True)

diff --git a/inginious/frontend/pages/lti.py b/inginious/frontend/pages/lti.py
@@ -70,7 +70,7 @@ def GET_AUTH(self):
         return self.template_helper.render("lti_bind.html", success=False, data=data, error="")
 
     def POST_AUTH(self):
-        data, error = self._get_lti_session_data_or_error()
+        data, error = self._get_lti_session_data()
         if error:
             return error
 
@@ -222,6 +222,7 @@ def _find_realname(self, launch_data):
         return launch_data["sub"]
 
 class LTILoginPage(INGIniousPage):
+    @property
     def is_lti_page(self):
         return True
 

diff --git a/inginious/frontend/submission_manager.py b/inginious/frontend/submission_manager.py
@@ -97,7 +97,7 @@ def _job_done_callback(self, submissionid, course, task, result, grade, problems
 
         self._plugin_manager.call_hook("submission_done", submission=submission, archive=archive, newsub=newsub)
 
-        if course.lti_send_back_grade:
+        if course.lti_send_back_grade():
             for username in submission["username"]:
                 self._lti_grade_manager.add(username,
                                               submission["courseid"],

diff --git a/setup.py b/setup.py
@@ -15,7 +15,6 @@
     "Flask-Mail==0.9.1",
     "itsdangerous==2.1.2",
     "Jinja2==3.1.3",
-    "lti==0.9.5",
     "PyLTI1p3==2.0.0",
     "msgpack==1.0.7",
     "natsort==8.4.0",