-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grouped actions and tasksets #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonygego
force-pushed
the
tasksets
branch
from
December 18, 2023 08:14
cf8141c
to
1095603
Compare
LGTM. The issue mentioned previously is resolved . |
nrybowski
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces grouped actions and tasksets under courses. Grouped actions concern the task dispenser admin view so that all the task parameters
Grouped actions:
data-
tag attribute and populates the modal fields based on the settings dictionary.Tasksets : as illustrated in the Figure below, courses have been divided in two separate objects where the remaining course is a task dispensing object located in database, while the tasksets actually manage the tasks themselves located in the filesystem.
To ease the implementation, the course factory has been duplicated. A taskset factory keep the YAML file loading part and the new course factory is a mockup above the database to avoid modifying too much code at a time.
The latter also imports older courses by checking for a
course.yaml
file and if some entry already exists in database for the course id associated to the folder name.Several pages have been added to manage the taskset where the task dispenser is also used to provide course templating at the time of instantiation.
The task dispenser is no more able to manage task files as courses only have read access to the tasksets.
TODO:
{"taskid2":1, "taskid1":0} -> ["taskid1", "taskid2"]