Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding docs to README #85

Merged
merged 79 commits into from
Oct 18, 2023
Merged

Adding docs to README #85

merged 79 commits into from
Oct 18, 2023

Conversation

ruaridhg
Copy link
Collaborator

@ruaridhg ruaridhg commented Oct 16, 2023 •
edited
Loading

Closes #71

@ruaridhg ruaridhg requested a review from sfmig October 16, 2023 15:36
@ruaridhg
Added details about how to avoid errors for UD props
10dd12e
@ruaridhg
define_prop init added
edd00ca
@ruaridhg
Properties.py imports collection of socket properties (geom-like) and…
f63e25c 
… property group of custom props
@ruaridhg
Combined string list operators with geom operators
07002e0
@ruaridhg
Added custom props as example of UI list - remove after integrated
22149aa
@ruaridhg
Skeleton of collection_UD, need to sort sockets and remove input nodes
fd824b6
@ruaridhg
Geom skeleton copied, could use subpanel for UIlist
deff6fa
@ruaridhg
minor refactoring with combination of UIlist and geom code loading wi…
c44ec8c 
…thout errors
@ruaridhg
Added UIlist as subpanel in UD panel
2901c03
@ruaridhg
UIlist print clear list add and remove works
b30f8df
@ruaridhg
Introducing collection gngs as UD props equivalent
f847286
@ruaridhg
Removed collection gngs - created branch off this one to include alte…
449d7de 
…rnative
@ruaridhg
Added collection_gngs.py
66ecab8
@ruaridhg
UIlist working and UD-sockets code in progress
72287f9
@ruaridhg
UIlist not disappearing and adds subpanels
9c69e6f
@ruaridhg
removed input and outputs from nodes code
b45165d
@ruaridhg
Removed old custom props folder
ed97d72
@ruaridhg
custom + custom_idx in properties.py works but needs moving into othe…
76612e1 
…r property_classes
@ruaridhg
changed UD props collection from UD socket properties to materials.so…
217c7ec 
…cket
@ruaridhg
UD property can appear in subplanel when hardcoded camera.location
16b11c1
@ruaridhg
Map props to attr for vector float3d working with attr_get_type
8ca6b57
@ruaridhg
able to split and pass in attribute_only_str
500a1f2
@ruaridhg
Tidy up before checking string is valid property
1ca8858
@ruaridhg
fake property ranch does not appear in subpanel - list_UD_props modified
2658421
@ruaridhg
Multiple Vector3 properties can be added
933b5c9
@ruaridhg
Added float 1d to attr_type, need to fix subpanels per attr_type
9ada8c8
sfmig
sfmig approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@sfmig sfmig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! Most comments are about making it a bit more succinct, remove stuff or clarifying some bits.

Some scripts look like they'd need to be removed before going public with the repo.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
doc/Install_addon_manually.md Outdated Show resolved Hide resolved
doc/Materials_geometry_panel.md Outdated Show resolved Hide resolved
doc/input_output.md Outdated Show resolved Hide resolved
doc/input_output.md Outdated Show resolved Hide resolved
@ruaridhg ruaridhg marked this pull request as ready for review October 17, 2023 16:14
@ruaridhg ruaridhg merged commit 884f596 into main Oct 18, 2023
2 of 4 checks passed
@ruaridhg ruaridhg deleted the rmg/docs_on_gh branch October 18, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfmig sfmig sfmig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation/Add-on release
2 participants
@ruaridhg @sfmig