Rebuilt plot_sinogram_profiles.py for 4D tof data
#1370
+313
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrisThielemans
requested changes
Feb 16, 2024
robbietuk
commented
Feb 20, 2024
| import numpy as np | ||
| import pytest | ||
|
|
||
| from examples.python.plot_projdata_profiles import compress_and_extract_1d_from_nd_array |
There was a problem hiding this comment.
If this pytest fails, it will likely be here. This worked on my debugger but failed on my CLI, it was probably an enviroment issue.
|
pytest fails with Could be solved by adding it to the pythonpath first (would need to be done both for GHA and AppVeyor). Alternatively, we do it better via #1392 |
|
@robbietuk want to finish this one? I think only needs
I'm hoping to release 6.3 soon, as it has a major bug fix. We could leave this for later if you have no time now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Built
plot_projdata_profiles.pyto replaceplot_sinogram_profiles.py. This allows for TOF data to be handled. I added significant error handling and what I hope is a better user experience. It does break backwards compatabity.I need to add a the ability to read v6.0 STIR projection data.
Testing performed
Include a pytest (commented out)
Related issues
#1363
Checklist before requesting a review
documentation/release_XXX.mdhas been updated with any functionality change (if applicable)