Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix OSX clang problems #1496

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

fix OSX clang problems #1496

wants to merge 2 commits into from
+40 −23

Commits on Aug 25, 2024

  1. re-enable OSX clang job

    @KrisThielemans
    KrisThielemans committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    fea050b View commit details
    Browse the repository at this point in the history

  2. change tests with intentional errors to catch std::runtime_error 

    Some tests check if errors are thrown. We caught any exception with
`catch (...)`. but that fails on OSX  Clang 18. Now we catch
`std::runtime_error`, which is more accurate anyway.

Fixes UCL#1490
    @KrisThielemans
    KrisThielemans committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    e27c966 View commit details
    Browse the repository at this point in the history