Cancer_modules_depression_epilepsy convert excel files to csv files #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @tbhallett. You may want to do a final review on this PR and merge when happy. I have already tested hashing DataFrames from both master and this branch. They are all outputting same hash Thanks |
joehcollins
reviewed
Nov 7, 2024
| @@ -0,0 +1,3 @@ | |||
| version https://git-lfs.github.com/spec/v1 | |||
| oid sha256:23f3b4cef6927114b414344c95a4c262691312049ce7dc101042230e895ff066 | |||
There was a problem hiding this comment.
do we need to keep this file?
joehcollins
reviewed
Nov 7, 2024
| @@ -0,0 +1,3 @@ | |||
| version https://git-lfs.github.com/spec/v1 | |||
| oid sha256:e5f0e3c22d3b82061dc884df42f3a304dd0cd1b205166d1e5460c8569eba0d53 | |||
There was a problem hiding this comment.
similarly if this is just documentation r.e. assumptions maybe it doesnt need to live on master?
# Conflicts: # resources/epilepsy/ResourceFile_Epilepsy.xlsx
…ew_modules' into mnjowe/convert_excel_to_csv_andrew_modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at converting excel files in all cancer modules plus epilepsy and depression modules
Person responsible - Andrew Phillips