-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make two node example graph #16
Conversation
mscroggs
commented
Mar 14, 2025
•
edited
Loading
edited
- Refactored node and graph so that a graph can be more easily created using functions as in Helper class for creating graph #7.
- Added functions to estimate mean and standard deviation from a graph
- Added test that one and two node graphs containing normal distributions give the correct mean and stdev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working example 🥳 🚀
Couple of small ruff
-please-ers in the Graph
class.
For the algorithms
module, I'm not convinced as to why the methods in there can't be part of the Graph
class itself, but I'm open to being convinced.
The test comments are mostly on a reduction in the number of cases. The two example tests have 16 & 32 test cases, respectively (which is not a bad thing, but some are likely redundant in terms of what they check).
Co-authored-by: Will Graham <[email protected]>
Co-authored-by: Will Graham <[email protected]>
…nto mscroggs/normal-example
Co-authored-by: Will Graham <[email protected]>
…nto mscroggs/normal-example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have put a few small suggestions in (if you agree with them, it should just be a case of "apply suggestion" and things won't break), otherwise looks good to go!
Co-authored-by: Will Graham <[email protected]>
Co-authored-by: Will Graham <[email protected]>
Co-authored-by: Will Graham <[email protected]>
Co-authored-by: Will Graham <[email protected]>