Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds additional rules to the ignore list as per internal Slack suggestions:
D105
missing docstrings on magic (dunder) methods - can potentially see the value in having such docstrings in some cases but don't think it should be required as typically their behaviour is obvious and function signature (and so interpretation of arguments) fixed by interface they are implementingANN
in testsD
rules in testsAlso have added
exclude = ["tests"]
to thetool.mypy
config section in thepyproject.toml
, for the same reasons asANN
has been ignored.