82/burger

[acholyn]

closes #82
also closes #90 , closes #91 , closes #97 ?

[tcouch]

Does this work for you at the moment? I encountered an error related to setting alt text on button icons in the login form, then when I commented out those lines it complained about an invalid React hook call?

Edit: should have said this is when I click the Login button in the burger menu

[acholyn]

I am also getting the error when clicking the login - it should be showing a login dialog, shouldn't it? I'll have a go tomorrow

[tcouch]

Slight problem where the login dialog doesn't fit on my laptop screen. It's ok if I make the window narrower.

[tcouch]

A work around to not receiving the text messages is to get the lamda to print the code and get it from cloudwatch. I found the following errors doing this though:

1. SmsInput -> handleSubmit function doesn't retrieve the code from the form before adding it to data. You need something like:

let formData = new FormData(e.target);
let code = formData.get("input");

2. With that in place, clicking the thumbs up icon to submit the code doesn't work, pressing enter works though
3. When the code gets sent to the API I get the following error: Error responding to SMS challenge InvalidParameterException: Missing required parameter USERNAME. When I logged the data being passed to respondToSMSChallenge to the console, phoneNumber was undefined. I think this is because line 89 you're calling getSMSVerificationCode with two parameters instead of three. I don't see setIsDialogVisible in LoginForm though...

[tcouch]

Best practice would probably be to make this a build variable, but not a biggy.

[tcouch]

If I close the browser then reload the page it's not showing me as logged in in the burger menu. The tokens are stored in localStorage though, so that mechanism to check on page load needs to be in place.

[acholyn]

ah ok

[acholyn]

have added it to the main menu component since that's where the button will display

[tcouch]

I feel like there should be a better, structured way to organise contributor details so we can iterate over a list of objects and display name, role, link etc. Maybe one for another issue.

[acholyn]

have we opened another issue or not yet?

[tcouch]

Done #100

[acholyn]

didn't quite work with amplify, so will redo the merge