Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OHRI-1879 Populate the correct HIV Enrollment data on the list #1670

Merged
merged 5 commits into from
Nov 1, 2023

Conversation

kirwea
Copy link
Contributor

@kirwea kirwea commented Oct 31, 2023

latest changes

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes the ticket number in the format OHRI-123 My PR title.
  • My work includes tests or is validated by existing tests.

Summary

Screenshots

Related Issue

Other

@kirwea kirwea closed this Oct 31, 2023
@kirwea kirwea reopened this Oct 31, 2023
Copy link
Contributor Author

@kirwea kirwea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ticket 1879:Changed to search using concepts in order to populate 'population category'

@kirwea
Copy link
Contributor Author

kirwea commented Nov 1, 2023

filled the data on the form and it displayed all data captured on the form

@arodidev arodidev requested a review from kajambiya November 1, 2023 09:26
@arodidev
Copy link
Contributor

arodidev commented Nov 1, 2023

LGTM.

@kajambiya kajambiya changed the title Merge pull request #1 from UCSF-IGHS/dev OHRI-1879 Populate the correct HIV Enrollment data on the list Nov 1, 2023
Copy link
Contributor

@kajambiya kajambiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kirwea
I've approved the PR but going forward, please use the PR naming convention just like what I've used above. Also for neatness's sake, you can't have 5 commits for a change of 1 line of code and the commit names should be descriptive of what the commit is doing.

@kajambiya kajambiya merged commit 2a96e36 into UCSF-IGHS:dev Nov 1, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants