(Upgrade): Update the esm-patient-common-lib version. #1846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadijahkyampeire
requested review from
arodidev,
ebambo and
VeronicaMukuhi
and removed request for
VeronicaMukuhi
|
@hadijahkyampeire please run |
alaboso
previously approved these changes
May 16, 2024
denniskigen
reviewed
May 16, 2024
Comment on lines
+42
to
+43
| "@openmrs/esm-framework": "*", | ||
| "@openmrs/esm-patient-common-lib": "*", |
There was a problem hiding this comment.
These should be X.x versions, right @ibacher?
There was a problem hiding this comment.
Yes, although I don't know that that's a hard requirement.
denniskigen
approved these changes
May 16, 2024
eudson
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
OHRI-123 My PR title.Summary
openmrsandcommon-libversions, this necessitated some changes since some workspace functions were moved to other places or are no longer being exported. But this fixes the workspace bugs we have been seeing.openmrsand common lib versions inside theohri-esm-commons-lib.Screenshots
Uploading Workspaces-fix.mov…
Related Issue
Other