populate mamba reports #1847
Merged
populate mamba reports #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| useEffect(() => { | ||
| if (patient) { | ||
| const lastIdentifier = patient.identifier |
There was a problem hiding this comment.
I have some reservations on this, the last pTracker id will probably have the latest date and one that is no longer valid has an end date., unless a patient can have more than one pTrackerId.
You can have a look at this file, they are fetching identifiers based on types : https://github.com/openmrs/openmrs-react-components/blob/0a739855da0262b6cb79f7e27ae5ff62932232f4/src/domain/patient/patientUtil.js#L108
patient.identifiers.find((identifier) => identifier.type.id === identifiersTypes.PTrackerIdentifierType);
should work
arodidev
reviewed
May 21, 2024
packages/esm-ohri-pmtct-app/src/views/mch-summary/mch-summary.component.tsx
Show resolved
Hide resolved
packages/esm-ohri-pmtct-app/src/views/mch-summary/mch-summary.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-ohri-pmtct-app/src/views/mch-summary/tabs/current-pregnancy.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-ohri-pmtct-app/src/views/mch-summary/tabs/current-pregnancy.component.tsx
Show resolved
Hide resolved
packages/esm-ohri-pmtct-app/src/views/mch-summary/tabs/current-pregnancy.component.tsx
Show resolved
Hide resolved
packages/esm-ohri-pmtct-app/src/views/mch-summary/tabs/current-pregnancy.component.tsx
Outdated
Show resolved
Hide resolved
|
@arodidev please re-review again |
arodidev
reviewed
May 24, 2024
packages/esm-ohri-pmtct-app/src/views/mch-summary/mch-summary.component.tsx
Outdated
Show resolved
Hide resolved
arodidev
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
OHRI-123 My PR title.This pr address the following;
Populate 3 mamba report for the MNCH Summary ;
Screenshots
Related Issue
Other