-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(chore) Bump carbon version and clean up some redundant components #1851
Conversation
674deb3
to
778e988
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good @CynthiaKamau , I was expecting to see the carbon version changed in the package.json, doesn't bumping change it?
@@ -102,7 +102,6 @@ | |||
"webpack-dev-server": "^4.8.1" | |||
}, | |||
"resolutions": { | |||
"@carbon/react": "1.17.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may not have full context on what's happening here, why was this removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its an older version and is used by default
I removed the older version in the main package.json, the packages have the same newer version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CynthiaKamau
Requirements
OHRI-123 My PR title
.Summary
This pr addresses the following :
Screenshots
Related Issue
Other