Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) Bump carbon version and clean up some redundant components #1851

Merged
merged 3 commits into from
May 22, 2024

Conversation

CynthiaKamau
Copy link
Contributor

@CynthiaKamau CynthiaKamau commented May 21, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes the ticket number in the format OHRI-123 My PR title.
  • My work includes tests or is validated by existing tests.

Summary

This pr addresses the following :

  • Bump carbon version
  • Bumping the openmrs version
  • Clean up some redundant components that now exist in carbon
  • Removed unused imports and routes after homepage migration
  • Update the jest config to ignore and be aware of important files
  • Add new eslint rules for files

Screenshots

Related Issue

Other

Copy link
Contributor

@hadijahkyampeire hadijahkyampeire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @CynthiaKamau , I was expecting to see the carbon version changed in the package.json, doesn't bumping change it?

@@ -102,7 +102,6 @@
"webpack-dev-server": "^4.8.1"
},
"resolutions": {
"@carbon/react": "1.17.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may not have full context on what's happening here, why was this removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its an older version and is used by default

@CynthiaKamau
Copy link
Contributor Author

This looks good @CynthiaKamau , I was expecting to see the carbon version changed in the package.json, doesn't bumping change it?

I removed the older version in the main package.json, the packages have the same newer version

Copy link
Contributor

@arodidev arodidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CynthiaKamau

@arodidev arodidev merged commit 02b422a into dev May 22, 2024
5 checks passed
@arodidev arodidev deleted the carbon-migration branch May 22, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants