Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OHRI-2211: Implement the cervical-cancer app schema based workflow #1857

Merged
merged 4 commits into from
Jun 6, 2024
Merged

OHRI-2211: Implement the cervical-cancer app schema based workflow #1857

merged 4 commits into from
Jun 6, 2024

Conversation

lucyjemutai
Copy link
Contributor

@lucyjemutai lucyjemutai commented Jun 4, 2024 •
edited
Loading

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes the ticket number in the format OHRI-123 My PR title.
  • My work includes tests or is validated by existing tests.

Summary

Implement the cervical-cancer app schema based workflow

Screenshots

screencast-from-04-06-2024-084006-alasiri_n4xYnUul.mp4

image

Related Issue

Other

@lucyjemutai lucyjemutai marked this pull request as ready for review June 5, 2024 11:49
hadijahkyampeire
hadijahkyampeire reviewed Jun 5, 2024
View reviewed changes
Copy link
Contributor

@hadijahkyampeire hadijahkyampeire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks, let's tweak the multipleConcepts implementation so that we don't need to change many places.

packages/esm-cervical-cancer-app/src/views/cacx-visits/cacx-config.json Outdated Show resolved Hide resolved
packages/esm-commons-lib/src/utils/encounter-list-config-builder.ts Outdated Show resolved Hide resolved
packages/esm-commons-lib/src/utils/encounter-list-config-builder.ts Outdated Show resolved Hide resolved
packages/esm-commons-lib/src/utils/encounter-list-utils.ts Outdated Show resolved Hide resolved
packages/esm-commons-lib/src/utils/encounter-list-utils.ts Outdated Show resolved Hide resolved
hadijahkyampeire
hadijahkyampeire reviewed Jun 6, 2024
View reviewed changes
Copy link
Contributor

@hadijahkyampeire hadijahkyampeire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think we need to make the date column a fixed width so that it doesn't wrap now that the screening method and screening results column have long texts. We also need to use the multiple obs for the screen method because it can all multiple methods.

hadijahkyampeire
hadijahkyampeire approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@hadijahkyampeire hadijahkyampeire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @lucyjemutai

@lucyjemutai lucyjemutai merged commit e24f880 into UCSF-IGHS:dev Jun 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadijahkyampeire hadijahkyampeire hadijahkyampeire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucyjemutai @hadijahkyampeire