Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(refactor) OHRI-2222 Implement the Maternal and Child Care package schema workflow #1858

Merged
merged 2 commits into from
Jun 10, 2024
Merged

(refactor) OHRI-2222 Implement the Maternal and Child Care package schema workflow #1858

merged 2 commits into from
Jun 10, 2024

Conversation

CynthiaKamau
Copy link
Contributor

…hema workflow

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes the ticket number in the format OHRI-123 My PR title.
  • My work includes tests or is validated by existing tests.

Summary

Screenshots

Before :
Screenshot 2024-06-05 at 18 14 02
Screenshot 2024-06-05 at 18 13 52

After :
Screenshot 2024-06-05 at 18 12 45
Screenshot 2024-06-05 at 18 12 33

Related Issue

Other

hadijahkyampeire
hadijahkyampeire reviewed Jun 6, 2024
View reviewed changes
Copy link
Contributor

@hadijahkyampeire hadijahkyampeire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed the pmtct to run on dev and the tables are different, I am not sure why but you probably need to check that, Also the EDD column needs to pass isDate true so that it formats the date, check the screenshots below.

  • Your local branch
Screenshot 2024-06-06 at 13 22 23
  • whats on dev
Screenshot 2024-06-06 at 13 22 39

@hadijahkyampeire hadijahkyampeire changed the title (refactor) OHRI-2222 Implement the Maternal and Child Care package sc… (refactor) OHRI-2222 Implement the Maternal and Child Care package sc…hema workflow Jun 8, 2024
@hadijahkyampeire hadijahkyampeire changed the title (refactor) OHRI-2222 Implement the Maternal and Child Care package sc…hema workflow (refactor) OHRI-2222 Implement the Maternal and Child Care package schema workflow Jun 8, 2024
@CynthiaKamau
Copy link
Contributor Author

@hadijahkyampeire : https://www.loom.com/share/9c19483daf814cb495ac1fac11f89055?sid=3d340310-ca69-46ca-905d-a1c87ae25f30

@CynthiaKamau CynthiaKamau force-pushed the OHRI-2222 branch 2 times, most recently from 5f051a0 to 66e1ee3 Compare June 10, 2024 11:39
@UCSF-IGHS UCSF-IGHS deleted a comment from hadijahkyampeire Jun 10, 2024
hadijahkyampeire
hadijahkyampeire approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@hadijahkyampeire hadijahkyampeire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CynthiaKamau let's merge this and also update the distro.

@CynthiaKamau
Copy link
Contributor Author

Thanks @CynthiaKamau let's merge this and also update the distro.

UCSF-IGHS/openmrs-distro-referenceapplication#228

@hadijahkyampeire hadijahkyampeire merged commit 09ee0ea into dev Jun 10, 2024
5 checks passed
@hadijahkyampeire hadijahkyampeire deleted the OHRI-2222 branch June 10, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadijahkyampeire hadijahkyampeire hadijahkyampeire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CynthiaKamau @hadijahkyampeire