-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(chore) Add ESLint Rules for React-Hooks #1862
Conversation
@nravilla you have some merge conflicts, would you resolve them please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nravilla the PR has conflicts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nravilla just a few comments
packages/esm-ohri-pmtct-app/src/views/mch-summary/tabs/current-pregnancy.component.tsx
Show resolved
Hide resolved
…staged integration to improve code quality checks.
Hi Hadijah, Eudson, thank you for your excellent catch (commented line and yarn.lock) during review yesterday. i have resolved all the issues that was raised. please let me know if you have any questions or concerns, Thank you so much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nravilla we can merge this.
Requirements
OHRI-123 My PR title
.Summary
Description:
This pull request introduces the following updates to the OHRI repository:
1. ESLint Rules for React-Hooks:
2. Husky and Lint-Staged Integration:
Screenshots
Related Issue
Other
The changes were tested by comparing localhost functionality with the OHRI-dev