Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(refactor) Dashboard UI Workflows: Implement HCT and TP dashboard schema workflows. #1873

Merged
merged 1 commit into from
Jun 19, 2024
Merged

(refactor) Dashboard UI Workflows: Implement HCT and TP dashboard schema workflows. #1873

merged 1 commit into from
Jun 19, 2024
+248 −765

Conversation

hadijahkyampeire
Copy link
Contributor

@hadijahkyampeire hadijahkyampeire commented Jun 18, 2024 •
edited
Loading

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes the ticket number in the format OHRI-123 My PR title.
  • My work includes tests or is validated by existing tests.

Summary

  • This PR refactors hiv care treatment and hiv testing services to use UI schema workflows.
  • Deleted the Lab Results folder which wasn't being used anywhere
  • Renaming the folder, that's mostly where many file changes are coming from.

Screenshots

Related Issue

Other

  • The summary cards are still hardcoded and its hard to build generic schemas for them

@CynthiaKamau CynthiaKamau mentioned this pull request Jun 19, 2024
Merged
2 tasks
ODORA0
ODORA0 approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@ODORA0 ODORA0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hadijahkyampeire
Copy link
Contributor Author

Thanks @ODORA0

@hadijahkyampeire hadijahkyampeire merged commit 3be44ad into dev Jun 19, 2024
5 checks passed
@hadijahkyampeire hadijahkyampeire deleted the OHRI-2225-hct-hp-home-dashboard-workflows branch June 19, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ODORA0 ODORA0 ODORA0 approved these changes

@eudson eudson Awaiting requested review from eudson

@CynthiaKamau CynthiaKamau Awaiting requested review from CynthiaKamau

@lucyjemutai lucyjemutai Awaiting requested review from lucyjemutai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hadijahkyampeire @ODORA0