Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Major Refactor): Naming - Inconsistent Usage of File Extensions and resource files. #1877

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

hadijahkyampeire
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes the ticket number in the format OHRI-123 My PR title.
  • My work includes tests or is validated by existing tests.

Summary

  • This PR includes renaming of some folders and file names.
  • It also includes some re-arranging of imports e.g putting the React import on line 1 and the style import at the bottom of all imports.
  • This PR also includes using of the name .resource of api files.

Screenshots

Related Issue

Caveat

  • This PR has no UI effects, so everything should be the same as before. Also the files changed might look many but most of them are due to the renaming.

@hadijahkyampeire
Copy link
Contributor Author

@ebambo do we also want to remove the ohri word some of our package and file names?

@hadijahkyampeire hadijahkyampeire force-pushed the OHRI-2236-refactor-file-names branch from 1227dac to 8c25265 Compare June 21, 2024 07:16
CynthiaKamau
CynthiaKamau previously approved these changes Jun 21, 2024
ODORA0
ODORA0 previously approved these changes Jun 21, 2024
Copy link
Contributor

@CynthiaKamau CynthiaKamau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hadijahkyampeire please check why the build is failing

@hadijahkyampeire hadijahkyampeire dismissed stale reviews from ODORA0 and CynthiaKamau via 4780099 June 21, 2024 09:25
Copy link
Contributor

@arodidev arodidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hadijahkyampeire hadijahkyampeire merged commit ad6e23f into dev Jun 21, 2024
5 checks passed
@hadijahkyampeire hadijahkyampeire deleted the OHRI-2236-refactor-file-names branch June 21, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants