Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OHRI-2253 Implement pmtct homepage dashboard workflows #1881

Merged
merged 1 commit into from
Jun 26, 2024
Merged

OHRI-2253 Implement pmtct homepage dashboard workflows #1881

merged 1 commit into from
Jun 26, 2024

Conversation

CynthiaKamau
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes the ticket number in the format OHRI-123 My PR title.
  • My work includes tests or is validated by existing tests.

Summary

  • This pr restructures pmtct files, showing the demarcation between files in the homepage and patient chart.

Screenshots

Screenshot 2024-06-21 at 11 24 43

Related Issue

Other

@CynthiaKamau CynthiaKamau force-pushed the OHRI-2253 branch 2 times, most recently from 63e3f43 to 54f0eec Compare June 21, 2024 11:47
hadijahkyampeire
hadijahkyampeire reviewed Jun 21, 2024
View reviewed changes
Copy link
Contributor

@hadijahkyampeire hadijahkyampeire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I missed this but the api.resource file should be taken out of the api folder and put in the src directory just as a file. Otherwise it looks good.

packages/esm-ohri-pmtct-app/src/pmtct/home-dashboard/mother-child-summary-tabs.component.tsx Outdated
@@ -1,10 +1,9 @@
import React from 'react';
import { Tabs, Tab, TabPanels, TabPanel, TabList } from '@carbon/react';
import styles from './ohri-patient-tabs.scss';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this style import at the bottom of the imports

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@CynthiaKamau CynthiaKamau force-pushed the OHRI-2253 branch 2 times, most recently from 587da8b to ce87b28 Compare June 21, 2024 14:40
hadijahkyampeire
hadijahkyampeire approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@hadijahkyampeire hadijahkyampeire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @CynthiaKamau

@CynthiaKamau CynthiaKamau merged commit 908d905 into dev Jun 26, 2024
5 checks passed
@CynthiaKamau CynthiaKamau deleted the OHRI-2253 branch June 26, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ODORA0 ODORA0 ODORA0 approved these changes

@hadijahkyampeire hadijahkyampeire hadijahkyampeire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CynthiaKamau @hadijahkyampeire @ODORA0