Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Improve encounter list behaviour #1886

Merged
merged 4 commits into from
Jun 27, 2024

Conversation

kajambiya
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes the ticket number in the format OHRI-123 My PR title.
  • My work includes tests or is validated by existing tests.

Summary

This PR fixes 2 bugs that were noted in the behaviour of the encounter list:

  1. In case the form launcher's visibility was based on some condition, upon saving an encounter, the list would be refreshed but the launch condition wouldn't hence leading to undesirable behaviour.
  2. The list would properly refresh whenever an encounter is deleted, however in cases where the list had only one entry, it wouldn't refresh after deletion.

Screenshots

Screen.Recording.2024-06-25.at.11.20.23.mov
form.launcher.mov

Related Issue

Other

@kajambiya kajambiya force-pushed the EncounterListRefactor branch from 34f77c3 to 3573ce4 Compare June 25, 2024 11:37
@alaboso alaboso merged commit 433407b into UCSF-IGHS:master Jun 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants