ConsoleEnablerMod overhaul #687
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ey instead of replacing the first one feat: Add some missing IsValid checks refactor: Removed obsolete parameters
… add them at the end of the array
…Case to match the previous style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Description
I don't know the reasons for the structure of the mod, but I couldn't find any harm in my improvements.
Originally the mod overwrites the first hotkey for the console with F10, if the game has default settings that allows you to open the console, it would overwrite the default key.
Also the most universal key to open a console on English keyboard layouts is ~ (tilde).
My changes add ~ in addition to F10, check if hotkeys are already set, if not the mod expands the ConsoleKeys array and adds ~ and F10 as additional options to open the console. Not only does it allow you to respect the game's settings, but it also allows other mods to add their own hotkeys to open the console.
Testing
I've tested the changes and I use it basically daily with my Cheat Console Commands Mod for Abiotic Factor.
For test purposes I've locally changed key mappings to F11 in my mod here and it worked. I could open the console with any of assigned keys.
Changelog changes
Like usually I'll write down the changes in the Changelog.md a bit later, maybe after an initial review, so I know which changes will remain.Added