-
Notifications
You must be signed in to change notification settings - Fork 75
docs: Adjust documents to reflect the new monorepo setup #1119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
1ae443d
to
7fd601d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
The legacy branch name here (which results in a dead link) needs to be replaced with "v3" here:
cli/docs/pages/extensibility/CustomTasks.md
Line 205 in 7fd601d
*For more details, see also [RFC 0012 UI5 CLI Extension API v3](https://github.com/UI5/cli/blob/rfc-ui5-tooling-extension-api-v3/rfcs/0012-UI5-Tooling-Extension-API-3.md#3-tasks-requiring-dependencies)* -
There are some changelogs of the packages which contain outdated links e.g. here:
cli/packages/builder/CHANGELOG.md
Line 105 in 7fd601d
Relates to: https://github.com/SAP/ui5-tooling/issues/701
I have updated the link in #1, but the second one is actually expected. There's a forwarding enabled in the old repo |
65f4d59
to
034afcd
Compare
Although, we have this link forwarding, I think we should replace legacy links nevertheless. This might create confusion or even dead links if the forwarding is not working anymore at some point. |
034afcd
to
19dbdab
Compare
Forwarding will work as long as we do not stop it. So we don't have to worry about this. |
8b12b31
to
be067d9
Compare
JIRA: CPOUI5FOUNDATION-975