Skip to content

Conversation

d3xter666
Copy link
Member

JIRA: CPOUI5FOUNDATION-975

@d3xter666 d3xter666 requested a review from a team September 25, 2025 13:15
@d3xter666 d3xter666 force-pushed the monorepo-adjust-contributing branch from 1ae443d to 7fd601d Compare September 30, 2025 11:18
@d3xter666 d3xter666 requested a review from maxreichmann October 6, 2025 12:53
Copy link
Member

@maxreichmann maxreichmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The legacy branch name here (which results in a dead link) needs to be replaced with "v3" here:

    *For more details, see also [RFC 0012 UI5 CLI Extension API v3](https://github.com/UI5/cli/blob/rfc-ui5-tooling-extension-api-v3/rfcs/0012-UI5-Tooling-Extension-API-3.md#3-tasks-requiring-dependencies)*

  2. There are some changelogs of the packages which contain outdated links e.g. here:

    Relates to: https://github.com/SAP/ui5-tooling/issues/701
    Due to our link forwarding, this might not be necessary :)

@d3xter666
Copy link
Member Author

  1. The legacy branch name here (which results in a dead link) needs to be replaced with "v3" here:
    *For more details, see also [RFC 0012 UI5 CLI Extension API v3](https://github.com/UI5/cli/blob/rfc-ui5-tooling-extension-api-v3/rfcs/0012-UI5-Tooling-Extension-API-3.md#3-tasks-requiring-dependencies)*
  2. There are some changelogs of the packages which contain outdated links e.g. here:
    Relates to: https://github.com/SAP/ui5-tooling/issues/701

    Due to our link forwarding, this might not be necessary :)

I have updated the link in #1, but the second one is actually expected. There's a forwarding enabled in the old repo

@d3xter666 d3xter666 requested a review from maxreichmann October 9, 2025 06:41
@d3xter666 d3xter666 force-pushed the monorepo-adjust-contributing branch from 65f4d59 to 034afcd Compare October 9, 2025 08:40
@maxreichmann
Copy link
Member

I have updated the link in #1, but the second one is actually expected. There's a forwarding enabled in the old repo

Although, we have this link forwarding, I think we should replace legacy links nevertheless. This might create confusion or even dead links if the forwarding is not working anymore at some point.
Perhaps, @flovogt knows more about this?

@d3xter666 d3xter666 force-pushed the monorepo-adjust-contributing branch from 034afcd to 19dbdab Compare October 9, 2025 11:15
@flovogt
Copy link
Member

flovogt commented Oct 10, 2025

I have updated the link in #1, but the second one is actually expected. There's a forwarding enabled in the old repo

Although, we have this link forwarding, I think we should replace legacy links nevertheless. This might create confusion or even dead links if the forwarding is not working anymore at some point. Perhaps, @flovogt knows more about this?

Forwarding will work as long as we do not stop it. So we don't have to worry about this.

@d3xter666 d3xter666 force-pushed the monorepo-adjust-contributing branch from 8b12b31 to be067d9 Compare October 10, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants