Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

32 import device export file from matrix #53

Merged
merged 6 commits into from
Jan 26, 2025

Conversation

Dan1elRoos
Copy link
Collaborator

Config-Files csv_mapping.json and ou_mapping.json currently contain test config parameter.
ldapObjects.csv contains test-cases:
If DeviceRoleCriteria.Mapping in csv_mapping.json is False the import-script will set DeviceRoles based on the DeviceRoles provided in the ldapObjects.csv, if set on True it will set DeviceRoles based on the ou_mapping.json.

@Dan1elRoos Dan1elRoos linked an issue Dec 18, 2024 that may be closed by this pull request
Copy link
Collaborator

@weidenba weidenba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to work quite well. However a minor refactoring (see comments) would improve the readability of the code.

@weidenba weidenba merged commit 7b3c46c into main Jan 26, 2025
4 checks passed
@weidenba weidenba deleted the 32-import-device-export-file-from-matrix branch January 26, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import Device Export File from Matrix
2 participants