Unittest CI #4
Merged
Unittest CI #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lbellmann
commented
Apr 10, 2024
lbellmann
commented
- added automatic unit tests
- moved db test flag from config file to pytest commandline arguments
- unit tests use Neo4J docker image
- staticmethod function usage only works with Python >=3.10
- triggered on push and pull requests to develop and main - main does not exist yet, fails? - checkout code, install requirements, trigger unit test, upload results - multiple python versions
- static method calls behaviour does not match Python 3.9, removed it - set python version >= 3.10 in setup.py - upgraded setup python action to v5
- originally global variables have to be set in config file - inconvenient for automated testing, would have to rewrite file every time - created pytest config with 4 parameters - flag if db test should be executed - neo4j host - neo4j port - user name - password
- password must be at least 8 characters - environment variable rename, was deprecated
- username/password were missing in cypher shell command
- added graphxplore to path for import
- warnings when db test where not triggered were faulty because of copy/paste
- tested Neo4J error return message when sending invalid Cypher statement - error message changed in Neo4J 5.xxx - now only beginning of error message is checked that is defined by GXP
- added unit test badge to README.md - renamed workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.