Skip to content

Commit

Permalink
Merge pull request #305 from UKGovernmentBEIS/dev
Browse files Browse the repository at this point in the history
Dev -> Staging
  • Loading branch information
Glenn-Clarke authored Aug 29, 2024
2 parents c208ac7 + 93b28cd commit a666542
Show file tree
Hide file tree
Showing 8 changed files with 423 additions and 28 deletions.
4 changes: 2 additions & 2 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@

<!--
<!--
Add the ticket number below and uncomment
[Link to Jira ticket](https://beisdigital.atlassian.net/browse/PC-####)
-->
Expand All @@ -17,6 +16,7 @@ Add a brief description of the change(s) you have made
- [ ] I have checked there are no unintentional line ending changes
- [ ] I have added tests where applicable
- [ ] If I have made any changes to the code, I have used the IDE auto-formatter on it
- [ ] If I have made any changes to website flow, I have updated the [Flow Miro Board](https://miro.com/app/board/uXjVK6F2rKo=/)
- [ ] If I have made any changes to website flow, I have checked forward and back behaviour is still consistent
- [ ] If I have made any changes to content strings or resource files, I have followed [the documentation](https://github.com/UKGovernmentBEIS/beis-simple-energy-advice-beta/blob/main/docs/LocalisationDocumentation.md)

Expand Down
9 changes: 8 additions & 1 deletion SeaPublicWebsite.BusinessLogic/Models/PropertyData.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,14 @@ public class PropertyData
{
public string Reference { get; set; }

public DateTime? RecommendationsFirstRetrievedAt { get; set; }
/// <summary>
/// Due to PC-1234, RecommendationsFirstRetrievedAt's name no longer reflects when it is assigned.
/// A constraint on the fix was that the data team cannot currently rewrite their
/// ingestion pipelines due to deadlines, therefore the column name in the database cannot change.
/// This timestamp is now assigned after the new-or-returning user question, at the start of the journey.
/// TODO-1240 Rename to reflect new position in journey
/// </summary>
public DateTime? RecommendationsFirstRetrievedAt { get; set; }

public OwnershipStatus? OwnershipStatus { get; set; }
public Country? Country { get; set; }
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit a666542

Please sign in to comment.