PC-1049: Update C# and .Net #349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glenn-Clarke
requested review from
jdgage and
samyou-softwire
and removed request for
jdgage and
samyou-softwire
Glenn-Clarke
force-pushed
the
PC-1049-Update-C#-and-.Net
branch
from
cc7bab6
to
ed12871
Compare
jdgage
reviewed
Aug 2, 2024
| run: dotnet restore --configfile nuget.config | ||
|
|
||
| - name: Build .Net code | ||
| env: {DOTNET_NUGET_SIGNATURE_VERIFICATION: false} |
There was a problem hiding this comment.
Looks like this hasn't worked, but for what it's worth I think Linux vs Windows might be a likely culprit here!
There was a problem hiding this comment.
I'm not completely sure. I think its happening on Windows now as well, since my PC restarted. I'm wondering if its some sort of caching thing?
I'm waiting on a windows build right now, to see if it builds faster the second time.
There was a problem hiding this comment.
Hmm yes fair enough. It is a bit annoying that we're using docker but not in a way that we can replicate what's happening in CI.
|
While I remember: don't forget to update the README! |
Glenn-Clarke
force-pushed
the
PC-1049-Update-C#-and-.Net
branch
from
3db3731
to
5d487e3
Compare
|
Cleaning up the attempted fixes while I think of it, so I've got a good base to revert to |
9 tasks
|
superseded by #365 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira ticket
Description
Updated references to C# 12 and .Net 8.0.
Preemptively fixed concurrency issues in StaticAssetsVersioningService
Checklist