Update openhtmltopdf. Add visual regression test script #166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
openhtmltopdf
. We were on quite an old version so there is risk of regression issues.However, since we now have an API, I've written a quick script to walk the API and generate all labels, and ran it against both this updated branch and the existing QA deployment (which still has the old version of
openhtmltopdf
). Then ran a pixel based diff of both images to check for any visual regression between the labels generated with the old and new versions ofopenhtmltopdf
.I've attached the diff images as a zip diff-images.zip (or you can run the script yourself). The image is a composite of diff, old version then new version, left to right. Only labels with any change have been included, so any not in the zip have not changed.
There are some interesting differences but they are all very minor, mostly related to text anti-aliasing. In some cases the new version seems more 'correct', such as the pluses on Range Hoods, or the radiator icon on Solid Fuel Boilers.
As part of approving this PR could you check the image diffs and confirm you're happy?