Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metrics returning strings #1018

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix metrics returning strings #1018

wants to merge 1 commit into from

Conversation

sdtblckgov
Copy link
Contributor

This PR contains:

  • New features
  • Changes to dev-tools e.g. CI config / github tooling
  • Docs
  • Bug fixes
  • Code refactor

What is the current behavior? (You can also link to an open issue here)

Inspect crashes when a metric returns a string, even though the acceptable return types are "Values" which can be strings.

What is the new behavior?

Inspect eval no longer crashes when returning a string value from a metric. Unfortunately, the viewer still crashes.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No

Other information:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant