-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/vscode 0325 #168
Feature/vscode 0325 #168
Conversation
We don’t serialize state (and we in fact close an open viewer when the editor is re-opened/reloaded)
This uses a generic host interface to show the viewer, allowing us to adapt to different IDEs.
eb4d19a
to
70c01e3
Compare
) { | ||
this.extensionUri_ = context.extensionUri; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens now to Inspect View in VS Code when you do a full reload? Does it restore itself (seems like it might be able to, even if it just goes back to the default view). I'm concerned that by removing this code we end up with a dead Inspect View panel, but LMK what you observe here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I observe that it doesn't orphan a window, but I agree with you that this seems sketchy. I am reverting that change.
This reverts commit 7a73130.
* Update to version 0.3.25 * poll for log files more frequently * Remove deserialization We don’t serialize state (and we in fact close an open viewer when the editor is re-opened/reloaded) * Add positron viewer support This uses a generic host interface to show the viewer, allowing us to adapt to different IDEs. * Update changelog * Avoid scrollbars on windows when showing progress * Improve wrapping behavarior of scores * Revert "Remove deserialization" This reverts commit 7a73130. --------- Co-authored-by: jjallaire <[email protected]>
* Update to version 0.3.25 * poll for log files more frequently * Remove deserialization We don’t serialize state (and we in fact close an open viewer when the editor is re-opened/reloaded) * Add positron viewer support This uses a generic host interface to show the viewer, allowing us to adapt to different IDEs. * Update changelog * Avoid scrollbars on windows when showing progress * Improve wrapping behavarior of scores * Revert "Remove deserialization" This reverts commit b050201f8fa34d7e29eeffb2b2eb4e535ea7fd1e. --------- Co-authored-by: jjallaire <[email protected]>
This PR contains:
What is the new behavior?