Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/vscode 0325 #168

Merged
merged 9 commits into from
Jul 31, 2024
Merged

Feature/vscode 0325 #168

merged 9 commits into from
Jul 31, 2024

Conversation

dragonstyle
Copy link
Collaborator

This PR contains:

  • New features
  • Changes to dev-tools e.g. CI config / github tooling
  • Docs
  • Bug fixes
  • Code refactor

What is the new behavior?

  • Poll for new log files more frequently
  • Support positron viewer panel

We don’t serialize state (and we in fact close an open viewer when the editor is re-opened/reloaded)
This uses a generic host interface to show the viewer, allowing us to adapt to different IDEs.
@dragonstyle dragonstyle marked this pull request as ready for review July 31, 2024 17:45
@dragonstyle dragonstyle force-pushed the feature/vscode-0325 branch from eb4d19a to 70c01e3 Compare July 31, 2024 18:02
@jjallaire jjallaire self-requested a review July 31, 2024 19:00
) {
this.extensionUri_ = context.extensionUri;

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens now to Inspect View in VS Code when you do a full reload? Does it restore itself (seems like it might be able to, even if it just goes back to the default view). I'm concerned that by removing this code we end up with a dead Inspect View panel, but LMK what you observe here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I observe that it doesn't orphan a window, but I agree with you that this seems sketchy. I am reverting that change.

@aisi-inspect aisi-inspect merged commit f1cf222 into main Jul 31, 2024
10 checks passed
@aisi-inspect aisi-inspect deleted the feature/vscode-0325 branch July 31, 2024 20:57
XkunW pushed a commit to VectorInstitute/inspect_ai that referenced this pull request Aug 22, 2024
* Update to version 0.3.25

* poll for log files more frequently

* Remove deserialization

We don’t serialize state (and we in fact close an open viewer when the editor is re-opened/reloaded)

* Add positron viewer support

This uses a generic host interface to show the viewer, allowing us to adapt to different IDEs.

* Update changelog

* Avoid scrollbars on windows when showing progress

* Improve wrapping behavarior of scores

* Revert "Remove deserialization"

This reverts commit 7a73130.

---------

Co-authored-by: jjallaire <[email protected]>
max-kaufmann pushed a commit that referenced this pull request Sep 9, 2024
* Update to version 0.3.25

* poll for log files more frequently

* Remove deserialization

We don’t serialize state (and we in fact close an open viewer when the editor is re-opened/reloaded)

* Add positron viewer support

This uses a generic host interface to show the viewer, allowing us to adapt to different IDEs.

* Update changelog

* Avoid scrollbars on windows when showing progress

* Improve wrapping behavarior of scores

* Revert "Remove deserialization"

This reverts commit b050201f8fa34d7e29eeffb2b2eb4e535ea7fd1e.

---------

Co-authored-by: jjallaire <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants