add APIConnectionError to rate limit errors for openai
#198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjallaire-aisi
approved these changes
Aug 6, 2024
lauritowal
pushed a commit
to lauritowal/inspect_ai
that referenced
this pull request
Aug 19, 2024
XkunW
pushed a commit
to VectorInstitute/inspect_ai
that referenced
this pull request
Aug 22, 2024
max-kaufmann
pushed a commit
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
What is the current behavior? (You can also link to an open issue here)
we don't handle APIConnectionError error properly for openAI, if I'm not mistaken. In anthropic.py an APIConnectionError is treated as a rate limit error and retried, but this is not the case in openai.py where we only retry on RateLimitError and APITimeoutError.
What is the new behavior?
now
is_rate_limitreturns true for APIConnectionErrors and they should be retried.Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no
Other information: