Always capture helm uninstall
output so that errors contain meaningful info
#49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
quiet
parameter ofuninstall()
is designed to work the same was as the Docker Compose implementation in Inspect - the idea being that the user shouldn't seehelm uninstall
output in most cases (except if they raninspect sandbox cleanup k8s
or the eval was cancelled/errored).Users have previously shared logs or screenshots of
RuntimeError: Helm uninstall failed. {"release": "bmkvavf7", "result": "not captured"}
. Usually this is a red herring (documented here) but the "not captured" bit is unhelpful. The reason thehelm uninstall
output was not captured is that theuninstall()
'squiet
parameter wasFalse
so the stdout/stderr of the command will have been written directly to the process's stdout/stderr.This PR:
helm uninstall
subprocesses, and "forwards" it to stdout/stderr only ifquiet=False
uninstall
function - in particular around the behaviour ofquiet
.