Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ADMIRALTY Card component theme #168

Open
UXdave-alexander opened this issue Mar 1, 2024 · 3 comments · Fixed by #328
Open

New ADMIRALTY Card component theme #168

UXdave-alexander opened this issue Mar 1, 2024 · 3 comments · Fixed by #328
Assignees
Labels
enhancement New feature or request released This issue/pull request has been released.

Comments

@UXdave-alexander
Copy link

Is your feature request related to a problem? Please describe.
Existing ADMIRALTY card is limited in design / functionality.

Describe the solution you'd like
A new CSS variable theme to enable customisaiotn of the card header colour, additional drop shadow on card and ability to pass custom HTML into card header
(https://www.figma.com/file/LlGaslsnzKuEl0HuACXk5c/UKHO-Figma-Design-System?type=design&node-id=3865%3A5788&mode=design&t=2CTd4zbnNPVDigId-1)

Describe alternatives you've considered
N / A - usage already functioning in Sailing Directions.

Additional context
image
image

@UXdave-alexander UXdave-alexander added the enhancement New feature or request label Mar 1, 2024
@KatiePUX
Copy link
Collaborator

KatiePUX commented Oct 9, 2024

Conversation with Dave Alexander re: need for this ticket now we have CSS variables and the new pill component is in progress, as users will be able to create this by enhancing the current card themselves using. Dave explained that user can now adjust the existing card it should not be a need anymore.

Could we create a story on the component page about enhancing the card and how this has been done in another application,,,?

@KatiePUX
Copy link
Collaborator

As in refinement all we need to do at this stage is add a story to the card component page that shows a more comprehensive/ complex example of adding HTML to card content and changing header colour.

Copy link
Contributor

🚀 Issue was released in v4.0.0 🚀

@github-actions github-actions bot added released This issue/pull request has been released. and removed prerelease This change is available in a prerelease. labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released This issue/pull request has been released.
Projects
None yet
3 participants