Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Updated card component stories to display customisable cards using the pill component. #328

Merged
merged 37 commits into from
Jan 14, 2025

Conversation

developernm
Copy link
Contributor

@developernm developernm commented Dec 30, 2024

fixes #168

This has been created off the back of Pill component, so ensure that goes first before this.

This has an additional 4 stories to demonstrate the use of CSS variables to make a customized card component.

CSS variables that can be overridden:
image

4 additional stories:
image
image
image
image

📦 Published PR as canary version: 4.0.0--canary.328.e84fafc.0

✨ Test out this PR locally via:

npm install @ukho/[email protected]
npm install @ukho/[email protected]
npm install @ukho/[email protected]
# or 
yarn add @ukho/[email protected]
yarn add @ukho/[email protected]
yarn add @ukho/[email protected]

Version

Published prerelease version: v4.0.0-next.9

Changelog

💥 Breaking Change

  • @ukho/admiralty-angular, @ukho/admiralty-core, @ukho/admiralty-react
    • Feat: Update autocomplete to hide chevron and removed typeahead #292 (@developernm)
  • @ukho/admiralty-core

🚀 Enhancement

🐛 Bug Fix

⚠️ Pushed to next

  • @ukho/admiralty-angular, @ukho/admiralty-core, @ukho/admiralty-react

🔩 Dependency Updates

  • @ukho/admiralty-angular, @ukho/admiralty-core, @ukho/admiralty-react

Authors: 4

@developernm developernm requested a review from a team as a code owner December 30, 2024 13:48
@developernm developernm linked an issue Dec 30, 2024 that may be closed by this pull request
@developernm developernm changed the base branch from main to next December 30, 2024 13:49
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-pebble-018989203-328.westeurope.azurestaticapps.net

Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-pebble-018989203-328.westeurope.azurestaticapps.net

Copy link
Contributor

@ecstaticrainbow ecstaticrainbow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-pebble-018989203-328.westeurope.azurestaticapps.net

Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-pebble-018989203-328.westeurope.azurestaticapps.net

@developernm developernm merged commit 7f090e2 into next Jan 14, 2025
13 checks passed
@developernm developernm deleted the 168-custom-card branch January 14, 2025 14:03
@github-actions github-actions bot added the prerelease This change is available in a prerelease. label Jan 14, 2025
Copy link
Contributor

🚀 PR was released in v4.0.0 🚀

@github-actions github-actions bot added released This issue/pull request has been released. and removed prerelease This change is available in a prerelease. labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New ADMIRALTY Card component theme
3 participants