Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(polymarket-notifier): make expiration check delay configurable #4808

Merged
merged 4 commits into from
Mar 13, 2025

Conversation

md0x
Copy link
Contributor

@md0x md0x commented Mar 12, 2025

Changes proposed in this PR:

  • Adds a new checkBeforeExpirationSeconds parameter to allow configuring how soon before expiration a proposal should be checked.
  • Updates relevant tests to ensure the filtering logic works as expected.
  • Improves flexibility in monitoring proposals close to expiration.

@md0x md0x marked this pull request as ready for review March 12, 2025 18:54
Copy link
Contributor

@daywiss daywiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for working on this

@@ -42,6 +44,7 @@ export interface MonitoringParams {
unknownProposalNotificationInterval: number;
retryAttempts: number;
retryDelayMs: number;
checkBeforeExpirationSeconds: number;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this makes sense but just want to double check, when specifying this parameter, this is how much time we need before dispute period ends?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that’s exactly right. The parameter specifies the number of seconds remaining until the dispute period ends so we only process proposals when there are fewer than that many seconds left before expiration.

md0x added 3 commits March 13, 2025 14:48
Signed-off-by: Pablo Maldonado <[email protected]>
Signed-off-by: Pablo Maldonado <[email protected]>
@md0x md0x merged commit 950a26a into master Mar 13, 2025
22 checks passed
@md0x md0x deleted the pablo/polymarket-delay-checks-param branch March 13, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants