Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1주차/머랭] 워크북 제출합니다. #15

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

meoraeng
Copy link

@meoraeng meoraeng commented Sep 24, 2024

✅ 워크북 체크리스트

  • 모든 핵심 키워드 정리를 마쳤나요?
  • 핵심 키워드에 대해 완벽히 이해하셨나요?
  • 이론 학습 이후 직접 실습을 해보는 시간을 가졌나요?
  • 미션을 수행하셨나요?
  • 미션을 기록하셨나요?

✅ 컨벤션 체크리스트

  • 디렉토리 구조 컨벤션을 잘 지켰나요?
  • pr 제목을 컨벤션에 맞게 작성하였나요?
  • pr에 해당되는 이슈를 연결하였나요?(중요)
  • 적절한 라벨을 설정하였나요?
  • 파트장에게 code review를 요청하기 위해 reviewer를 등록하였나요?
  • 닉네임/main 브랜치의 최신 상태를 반영하고 있는지 확인했나요?(매우 중요!)

📌 주안점

@meoraeng meoraeng requested a review from qmean September 24, 2024 17:41
@meoraeng meoraeng self-assigned this Sep 24, 2024
@meoraeng meoraeng linked an issue Sep 24, 2024 that may be closed by this pull request
Copy link
Contributor

@qmean qmean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 머랭! 지금 밖이라 집가서 빠르게 리뷰해드릴게요!
라벨만 붙여주시면 감사하겠습니다!

Copy link
Contributor

@qmean qmean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 머랭! 키워드 미션과 더불어 추가과제까지 예제코드로 너무 잘 작성해주신것 같습니다! 머지해 주시면 되겠습니다 👍

Copy link
Contributor

@qmean qmean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엇 제가 타겟브랜치를 못봤었네요.. 타겟 브랜치만 수정해 주시면 감사하겠습니다!

Copy link
Contributor

@qmean qmean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혹시몰라서.. 일단 머지 막아둘게요 타겟 브랜치 변경후 다시 요청해주시면 됩니다!

@meoraeng meoraeng changed the base branch from main to meoraeng/main September 26, 2024 00:13
@meoraeng
Copy link
Author

아차.. 브랜치 체크를 못했군요
브랜치 변경하고 라벨 달아뒀습니다 !

Copy link
Contributor

@qmean qmean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 고생하셨습니다! 머지해주시면 됩니다!

@meoraeng meoraeng merged commit 2f6f527 into UMC-Inha:meoraeng/main Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chapter01_Database 설계
2 participants